[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Xen-devel] [PATCH] xen: Clean up includes

From: Stefano Stabellini
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] xen: Clean up includes
Date: Tue, 14 Jun 2016 15:37:01 +0100 (BST)
User-agent: Alpine 2.10 (DEB 1266 2009-07-14)

On Tue, 14 Jun 2016, Peter Maydell wrote:
> On 30 May 2016 at 16:54, Stefano Stabellini <address@hidden> wrote:
> > On Tue, 24 May 2016, Peter Maydell wrote:
> >> Clean up includes so that osdep.h is included first and headers
> >> which it implies are not included manually.
> >>
> >> This commit was created with scripts/clean-includes.
> >>
> >> Signed-off-by: Peter Maydell <address@hidden>
> >
> > Reviewed-by: Stefano Stabellini <address@hidden>
> >
> > Added to my queue
> Hi; did this patch get lost? You've done a xen pullreq since
> this but this patch wasn't in it.

I didn't lose it, I thought you had already committed it as
21cbfe5f37aaa3a13d3af28454e762c05be67429, but I realize now that
although they have the same commit message, they are not the same patch.

I was wondering how it got upstream given that I didn't send a pull
request for it. Mystery solved. Next time it might be good to avoid
having multiple patches touching similar code with exactly the same
commit description.

I'll send another pull request today.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]