[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-ppc] Determining interest in PPC e500spin, yield,

From: Thomas Huth
Subject: Re: [Qemu-devel] [Qemu-ppc] Determining interest in PPC e500spin, yield, and openpic patches
Date: Thu, 16 Jun 2016 08:25:45 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0


On 15.06.2016 22:12, address@hidden wrote:
> When e500 PPC is booted multi-core, the non-boot cores are started via
> the spin table.  ppce500_spin.c:spin_kick() calls
> mmubooke_create_initial_mapping() to allocate a 64MB TLB entry, but
> the created TLB entry is only 256KB.
> The root cause is that the function computing the size of the TLB
> entry, namely booke206_page_size_to_tlb assumes MAS1.TSIZE as defined
> by latter PPC cores, specifically n to the power of FOUR * 1KB. The
> result is then used by mmubooke_create_initial_mapping using
> MAS1_TSIZE_SHIFT, but MAS1_TSIZE_SHIFT is defined assuming TLB entries
> are n to the power of TWO * 1KB. I.e., a difference of shift=7 or
> shift=8.
> Simply changing MAS1_TSIZE_SHIFT from 7 to 8 is not appropriate since
> the macro is used elsewhere.
> The following patch has a fix for that, and also raises a separate
> issue that I'd be happy to resolve after getting some guidance.

Thanks for your patch! However, patches have to follow certain rules
before they can be included in QEMU. Please read through
to get a basic understanding of these rules first. Especially important
for your patch:

- You need to add a "Signed-off-by" line to the patch description to
  state that you've read and understood http://developercertificate.org/

- Run your patch through scripts/checkpatch.pl and the fix style issue

- Please address only one issue per patch. The issue that you've
  mentioned in the comment should be handled with a separate discussion
  (and a separate patch once there is a solution)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]