[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comment
Re: [Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comments
Thu, 16 Jun 2016 18:19:23 +0200
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Eric Blake <address@hidden> writes:
> Fix the regex comments describing what we parse as JSON. No change
> to the lexer itself, just to the comments:
> - The "" and '' string construction was missing alternation between
> different escape sequences
> - The construction for numbers forgot to handle optional leading '-'
> - The construction for numbers was grouped incorrectly so that it
> didn't permit '0.1'
> - The construction for numbers forgot to mark the exponent as optional
> - No mention that our '' string and "\'" are JSON extensions
> - No mention of our %d and related extensions when constructing JSON
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
I'll take this one through qapi-next. Thanks!
[Qemu-devel] [PATCH 4/4] qobject: Output valid JSON for non-finite numbers, Eric Blake, 2016/06/09
[Qemu-devel] [PATCH 2/4] checkpatch: There is no qemu_strtod(), Eric Blake, 2016/06/09