[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] scsi: esp: remove handling of SATN/STOP

From: P J P
Subject: Re: [Qemu-devel] [PATCH v2] scsi: esp: remove handling of SATN/STOP
Date: Fri, 17 Jun 2016 16:38:52 +0530 (IST)

+-- On Fri, 17 Jun 2016, Paolo Bonzini wrote --+
| The implementation of SATN/STOP is completely busted.  The idea
| would be that the next DMA read is for a SCSI message and after
| that the adapter would transition to the command phase.
| The recent fix to SATN/STOP broke migration, which is one more
| reason to drop SATN/STOP handling completely.  It is only used
| in practice to send 3-byte messages (target number + tag type
| + tag number) for tagged command queuing on adapters that lack
| the SATN3 command, and we do not advertise support for TCQ.
| Signed-off-by: Paolo Bonzini <address@hidden>
| ---

Looks good.
Reviewed-by: Prasad J Pandit <address@hidden>

Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

reply via email to

[Prev in Thread] Current Thread [Next in Thread]