[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] vmxnet3: Fix reading/writing guest memory speci

From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH] vmxnet3: Fix reading/writing guest memory specially when behind an IOMMU
Date: Mon, 20 Jun 2016 10:54:14 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0

On 2016年06月18日 18:24, KarimAllah Ahmed wrote:
When a PCI device lives behind an IOMMU, it should use 'pci_dma_*' family of
functions when any transfer from/to guest memory is required while
'cpu_physical_memory_*' family of functions completely bypass any MMU/IOMMU in
the system.

vmxnet3 was exclusively using 'cpu_physical_memory_*' family of functions which
works fine with the default QEMU setup where IOMMU is not enabled but fails
miserably when IOMMU is enabled. This commit converts all such instances in
favor of 'pci_dma_*'

Cc: Dmitry Fleytman<address@hidden>
Cc: Jason Wang<address@hidden>
Cc: Anthony Liguori<address@hidden>
Signed-off-by: KarimAllah Ahmed<address@hidden>
  hw/net/vmware_utils.h  |  55 +++++++------
  hw/net/vmxnet3.c       | 207 +++++++++++++++++++++++++++----------------------
  hw/net/vmxnet_tx_pkt.c |  19 ++---
  hw/net/vmxnet_tx_pkt.h |   8 +-
  4 files changed, 161 insertions(+), 128 deletions(-)

Thanks for the patch, but could you pls rebase this on top of master?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]