[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 2/4] range: Eliminate direct Range member ac
Re: [Qemu-devel] [PATCH RFC 2/4] range: Eliminate direct Range member access
Mon, 20 Jun 2016 09:26:10 +0200
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
"Michael S. Tsirkin" <address@hidden> writes:
> On Wed, Jun 15, 2016 at 10:41:48PM +0200, Markus Armbruster wrote:
>> Users of struct Range mess liberally with its members, which makes
>> refactoring hard. Create a set of methods, and convert all users to
>> call them instead of accessing members. The methods have carefully
>> worded contracts, and use assertions to check them.
>> To help with tracking down the places that access members of struct
>> Range directly, hide the implementation of struct Range outside of
>> range.c by trickery. The trickery will be dropped in the next commit.
>> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> I guess you want me to merge this because of the changes in pc and pci?
Yes, please (whole series, once respun without the RFC).
- Re: [Qemu-devel] [PATCH RFC 1/4] log: Clean up misuse of Range for -dfilter, (continued)