[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/10] qdev: Don't stop applying globals on firs

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 01/10] qdev: Don't stop applying globals on first error
Date: Mon, 20 Jun 2016 09:43:15 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eduardo Habkost <address@hidden> writes:

> qdev_prop_set_globals_for_type() stops applying global properties
> on the first error. It is a leftover from when QEMU exited on any
> error when applying global property. Now we print a warning about
> the first error, bug ignore all other global properties after it.

Might want to add "Messed up in commit 25f8dd9."

> For example, the following command-line will not set CPUID level
> to 3, but will warn only about "x86_64-cpu.vendor" being ignored.
>   $ ./x86_64-softmmu/qemu-system-x86_64 \
>       -global x86_64-cpu.vendor=x \
>       -global x86_64-cpu.level=3
>   qemu-system-x86_64: Warning: global x86_64-cpu.vendor=x ignored: Property 
> '.vendor' doesn't take value 'x'
> Fix this by not returning from qdev_prop_set_globals_for_type()
> on the first error.
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]