[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] build: Use $(CC) for compiling .S files
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] build: Use $(CC) for compiling .S files |
Date: |
Mon, 20 Jun 2016 14:43:36 +0100 |
On 18 June 2016 at 07:47, Richard Henderson <address@hidden> wrote:
> We fail to pass to AS all of the different flags that
> may be required for a given set of CFLAGS. Rather than
> figuring out the host-specific mapping, it's better to
> allow the compiler driver to do that.
>
> This fixes e.g. ../configure --cpu=i686, but would also
> be required for ppc and sparc.
>
> Signed-off-by: Richard Henderson <address@hidden>
This is basically reverting commit 3dd46c78525a30e98c68 from
2013, which explicitly switched to using separate CPP and
AS steps "because the C compiler could be unsuitable", by
which I think it means the failure described here:
https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00558.html
where if the compiler is clang it might not be able to
handle some of the code we use in the optionrom assembly
even though 'as' can.
Does that no longer apply ?
thanks
-- PMM