[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] i386: pci-assign: Fix MSI-X table size

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] i386: pci-assign: Fix MSI-X table size
Date: Mon, 20 Jun 2016 16:54:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 18/06/2016 22:42, Ido Yariv wrote:
> The current code creates a whole page mmio region for the MSI-X table
> size.
> However, the page containing the MSI-X table may contain other registers
> not related to MSI-X. Creating an mmio region for the whole page masks
> such registers and may break drivers in the guest OS.
> Since maximal number of entries is known, use that instead to deduce the
> table size when setting up the mmio region.
> Signed-off-by: Ido Yariv <address@hidden>

I can take this patch, but I'd like to warn you that pci-assign is
deprecated (and replaced by VFIO).  I seem to recall VFIO does this
correctly, but it would be great if you could check that.

Also, I would prefer the mmap/munmap to keep using MSIX_PAGE_SIZE, just
to limit the number of things that could break.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]