[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/15] blockjob: Add 'id' field to 'BlockJobInfo
Re: [Qemu-devel] [PATCH 15/15] blockjob: Add 'id' field to 'BlockJobInfo' and all BLOCK_JOB_* events
Mon, 20 Jun 2016 21:14:04 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1
On 09.06.2016 10:20, Alberto Garcia wrote:
> Now that all jobs have an ID and all QMP commands that create and
> operate on block jobs can specify one we can finally expose the ID in
> all BLOCK_JOB_* events and the BlockJobInfo structure.
> This modifies the output of several iotests, but now we have full
> control of the job IDs so this patch updates the affected ones.
> Signed-off-by: Alberto Garcia <address@hidden>
> blockjob.c | 6 +++++-
> docs/qmp-events.txt | 4 ++++
> qapi/block-core.json | 18 ++++++++++++++++--
> tests/qemu-iotests/095 | 2 +-
> tests/qemu-iotests/095.out | 2 +-
> tests/qemu-iotests/124 | 3 ++-
> tests/qemu-iotests/141 | 6 +++++-
> tests/qemu-iotests/141.out | 14 +++++++-------
> tests/qemu-iotests/144 | 1 +
> tests/qemu-iotests/144.out | 4 ++--
> 10 files changed, 44 insertions(+), 16 deletions(-)
Looks good, but in the meantime iotest 156 has been added which needs
the same treatment as the rest.
Also, I personally wouldn't mind making use of the IDs where trivial.
For example, you can just replace the "'device': 'virtio0'" by "'id':
'commit1'" in the block-job-complete invocation in 144. Optional, of
course, but would make sense.
Description: OpenPGP digital signature