[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 3/4] translate-all.c: Compute L1 page tab
Re: [Qemu-devel] [RFC PATCH v1 3/4] translate-all.c: Compute L1 page table properties at runtime
Tue, 21 Jun 2016 13:57:53 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1
On 21/06/2016 13:53, Peter Maydell wrote:
>>> >> object_property_add_child(object_get_root(), "machine",
>>> >> OBJECT(current_machine), &error_abort);
>>> >> +
>>> >> + init_l1_page_table_param();
>> > Please call this from cpu_exec_init_all instead.
> If you're going to call it that early (ie before machine init)
> than I think we might as well just call it from the existing
> page_init() function in translate-all.c instead, right?
> (gets called when the tcg accelerator is inited; we don't need
> to set up the l1 map if we're not using TCG).
Yes, good idea.
[Qemu-devel] [RFC PATCH v1 3/4] translate-all.c: Compute L1 page table properties at runtime, vijayak, 2016/06/13