[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] cadence_uart: shouldn't assume qemu_chr_fe_write() retu
Re: [Qemu-devel] cadence_uart: shouldn't assume qemu_chr_fe_write() returns non-negative value
Tue, 21 Jun 2016 08:33:18 -0700
On Tue, Jun 21, 2016 at 5:35 AM, Peter Maydell <address@hidden> wrote:
> This is something coverity spotted: in cadenc_uart_xmit(), the
> code assumes that qemu_chr_fe_write() always returns the number
> of bytes written, and subtracts it from the tx_count. However
> it can also return a negative value indicating an error.
> Could one of you fix this please? Skipping the adjustment of
> tx_count and the memmove() if ret is negative should do I think.
I'll look at it and send a patch out.
> -- PMM