[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] trace: [linux-user] Commandline arguments t

From: Lluís Vilanova
Subject: Re: [Qemu-devel] [PATCH 1/2] trace: [linux-user] Commandline arguments to control tracing
Date: Wed, 22 Jun 2016 11:53:33 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake writes:

> On 06/21/2016 07:23 AM, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---
>> linux-user/main.c |   28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)

>> +    {"trace-enable", "QEMU_TRACE_ENABLE",true,  handle_arg_trace_enable,
>> +     "name",       "enable tracing of specified event names (pass '?' to 
>> show a list of events)"},

> ? is a shell metacharacter, and it requires quoting to be safe against
> globbing against any single-letter files in the current directory.  A
> better suggestion would be to pass 'help' to show a list of events.

Right. The code internally uses 'is_help_option()' (also used by "-trace
enable=" and "-cpu" in vl.c), which accepts both '?' and 'help'. I'll just cite
using 'help' (even if both are accepted).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]