[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 2/4] i386: publish advised value of MSR_IA32_

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v5 2/4] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg
Date: Wed, 22 Jun 2016 19:08:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1

On 22/06/2016 08:56, Haozhong Zhang wrote:
> +
> +    val = g_malloc(sizeof(*val));
> +    *val = feature_control_bits | FEATURE_CONTROL_LOCKED;

As noticed by Laszlo, you need to use cpu_to_le64 here.  The maintainer
can fix it, I think.


> +    fw_cfg_add_file(pcms->fw_cfg, "etc/msr_feature_control", val, 
> sizeof(*val));
> +}

reply via email to

[Prev in Thread] Current Thread [Next in Thread]