[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 PATCH 10/14] tcg/tci: Add support for fence
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [RFC v3 PATCH 10/14] tcg/tci: Add support for fence |
|
Date: |
Wed, 22 Jun 2016 13:25:50 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 06/22/2016 12:57 PM, Sergey Fedorov wrote:
>> > @@ -1236,6 +1236,9 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env,
>> > uint8_t *tb_ptr)
>> > tcg_abort();
>> > }
>> > break;
>> > + case INDEX_op_mb:
>> > + smp_mb();
> I think we could distinguish smp_rmb(), smp_wmb() and smp_mb() here.
I don't. The extra unpredictable branch is not likely to be worthwhile.
If we want anything finer grained for tci, would should revisit the complete
rewrite that I did a year to two ago.
r~