[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/10] qdev: Don't stop applying globals on f
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/10] qdev: Don't stop applying globals on first error |
Date: |
Thu, 23 Jun 2016 08:36:43 -0300 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, Jun 23, 2016 at 09:40:54AM +0200, Markus Armbruster wrote:
> Eduardo Habkost <address@hidden> writes:
>
> > Since commit 25f8dd9, qdev_prop_set_globals_for_type() stops
> > applying global properties on the first error. It is a leftover
> > from when QEMU exited on any error when applying global property.
> > Now we print a warning about the first error, bug ignore all
> > other global properties after it.
>
> Actually, we've stopped since forever. Before commit 25f8dd9, that was
> okay. Since commit, it isn't. Suggest:
>
> qdev_prop_set_globals_for_type() stops applying global properties on the
> first error. It is a leftover from when QEMU exited on any error when
> applying global property. Commit 25f8dd9 changed the fatal error to a
> warning, but neglected to drop the stopping. Fix that.
Fixed that. Thanks!
--
Eduardo
- [Qemu-devel] [PATCH v2 00/10] globals: Clean up validation and error checking, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 01/10] qdev: Don't stop applying globals on first error, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 02/10] qdev: Eliminate qemu_add_globals() function, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 05/10] machine: Add machine_register_compat_props() function, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 08/10] qdev: Eliminate GlobalProperty 'used' and 'user_provided' fields, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 06/10] vl: Set errp to &error_abort on machine compat_props, Eduardo Habkost, 2016/06/20
- [Qemu-devel] [PATCH v2 09/10] qdev: Remove qdev_prop_register_global_list(), Eduardo Habkost, 2016/06/20