[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 10/10] machine: Skip global registration for

From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH v2 10/10] machine: Skip global registration for non-existing classes
Date: Thu, 23 Jun 2016 08:55:02 -0300
User-agent: Mutt/1.6.1 (2016-04-27)

On Thu, Jun 23, 2016 at 10:26:49AM +0200, Markus Armbruster wrote:
> Eduardo Habkost <address@hidden> writes:
> > MachineClass::compat_props may point to class names that are not
> > compiled into the QEMU binary. Skip registering those as global
> > properties. This will allow the qdev global property code to
> > implement stricter checks on the global property values in the
> > future.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
> Not sure what those stricter checks might be, but that's okay.

I would like to make qdev_prop_register_global() validate the
class and property names. It should be doable for the
!cannot_destroy_with_object_finalize_yet classes.

Maybe even the property value could be validated by actually
setting the property in a temporary object, but I am not looking
forward to audit every single property setter in QEMU to ensure
this is safe.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]