[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure |
Date: |
Thu, 23 Jun 2016 12:06:35 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 06/23/2016 11:21 AM, Sergey Sorokin wrote:
Yes, I thought about it. tcg_canonicalize_memop() is good place too.
But do you think that get_alignment_bits() is not good enough?
I think the earlier a target-* translator problem is diagnosed the better.
Leaving things in get_alignment_bits is ok, so long as we then invoke
get_alignment bits in tcg_canonicalize_memop. Perhaps
static inline TCGMemOp tcg_canonicalize_memop(TCGMemOp op, bool is64, bool st)
{
/* Trigger the asserts within sooner rather than later. */
(void)get_alignment_bits(op);
...
}
r~
- [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure, Sergey Sorokin, 2016/06/22
- Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure, Richard Henderson, 2016/06/22
- Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure, Sergey Sorokin, 2016/06/22
- Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure, Richard Henderson, 2016/06/22
- Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure, Sergey Sorokin, 2016/06/23
- Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure, Richard Henderson, 2016/06/23
- Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure, Sergey Sorokin, 2016/06/23
- Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure, Sergey Sorokin, 2016/06/23
- Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure, Richard Henderson, 2016/06/23
- Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure, Sergey Sorokin, 2016/06/23
- Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure,
Richard Henderson <=