[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 15/22] block: Switch transfer length bounds t
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 15/22] block: Switch transfer length bounds to byte-based |
Date: |
Fri, 24 Jun 2016 14:06:19 +0800 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, 06/23 16:37, Eric Blake wrote:
> Sector-based limits are awkward to think about; in our on-going
> quest to move to byte-based interfaces, convert max_transfer_length
> and opt_transfer_length. Rename them (dropping the _length suffix)
> so that the compiler will help us catch the change in semantics
> across any rebased code, and improve the documentation. Use unsigned
> values, so that we don't have to worry about negative values and
> so that bit-twiddling is easier; however, we are still constrained
> by 2^31 of signed int in most APIs.
>
> When a value comes from an external source (iscsi and raw-posix),
> sanitize the results to ensure that opt_transfer is a power of 2.
>
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
- Re: [Qemu-devel] [PATCH v3 08/22] block: Give nonzero result to blk_get_max_transfer_length(), (continued)
- [Qemu-devel] [PATCH v3 02/22] block: Document supported flags during bdrv_aligned_preadv(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 06/22] iscsi: Advertise realistic limits to block layer, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 05/22] nbd: Advertise realistic limits to block layer, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 07/22] scsi: Advertise limits by blocksize, not 512, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 01/22] block: Tighter assertions on bdrv_aligned_pwritev(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 13/22] block: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 10/22] iscsi: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 15/22] block: Switch transfer length bounds to byte-based, Eric Blake, 2016/06/23
- Re: [Qemu-devel] [PATCH v3 15/22] block: Switch transfer length bounds to byte-based,
Fam Zheng <=
- [Qemu-devel] [PATCH v3 17/22] block: Switch discard length bounds to byte-based, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 14/22] block: Set default request_alignment during bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 21/22] block: Fix error message style, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 03/22] block: Fix harmless off-by-one in bdrv_aligned_preadv(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 12/22] raw-win32: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 11/22] qcow2: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23