[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/6] serial: flow control fixes
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/6] serial: flow control fixes |
Date: |
Fri, 24 Jun 2016 10:30:06 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
* Paolo Bonzini (address@hidden) wrote:
> v1->v2:
> - use guint for GSource tags
> - move migration patch last because it set watch_tag but never read it
> - add more details in errors
> - don't drop tsr_retry sanity check in migration patch
Thanks,
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Note you have a 1 character typo in both of your errors,
+ "(tsr empty, tsr_retry=%d", s->tsr_retry);
+ "(tsr not empty, tsr_retry=0");
I think you want to add the close brackets, i.e.:
+ "(tsr empty, tsr_retry=%d)", s->tsr_retry);
+ "(tsr not empty, tsr_retry=0)");
Dave
>
> Paolo Bonzini (6):
> serial: make tsr_retry unsigned
> serial: simplify tsr_retry reset
> serial: separate serial_xmit and serial_watch_cb
> char: change qemu_chr_fe_add_watch to return unsigned
> serial: remove watch on reset
> serial: reinstate watch after migration
>
> hw/char/cadence_uart.c | 9 ++++---
> hw/char/serial.c | 67
> ++++++++++++++++++++++++++++++++++++------------
> include/hw/char/serial.h | 3 ++-
> include/sysemu/char.h | 16 ++++++++++--
> net/vhost-user.c | 2 +-
> qemu-char.c | 8 +++---
> 6 files changed, 78 insertions(+), 27 deletions(-)
>
> --
> 2.5.5
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v2 0/6] serial: flow control fixes, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 1/6] serial: make tsr_retry unsigned, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 5/6] serial: remove watch on reset, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 4/6] char: change qemu_chr_fe_add_watch to return unsigned, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 2/6] serial: simplify tsr_retry reset, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 3/6] serial: separate serial_xmit and serial_watch_cb, Paolo Bonzini, 2016/06/23
- [Qemu-devel] [PATCH v2 6/6] serial: reinstate watch after migration, Paolo Bonzini, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 0/6] serial: flow control fixes,
Dr. David Alan Gilbert <=