[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove
Date: Fri, 24 Jun 2016 14:08:52 +0200

On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin <address@hidden> wrote:
>> > Maybe what you want is a need_unlink feature.
>> > Set it for unix sockets only, that would make some sense.
>> Oh perhaps what you mean is that if the fd was passed, we should cleanup the 
>> unix socket? Yes, I think we should do that then. I'll update the series.

Actually it's not possible to pass a listening fd to a socket chardev
today (the path argument doesn't understand /dev/fdset), so only path
created by qemu will be cleaned up.

> I'd like it better contained - that's all. So let's set a flag that says
> "must unlink" as opposed to "it's listening".

You suggest to rename QIO_CHANNEL_FEATURE_LISTEN to
flag? I don't think that brings anything useful here.

What would you think Daniel?

Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]