[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 06/24] vhost-user: check vhost_user_write() retu

From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH 06/24] vhost-user: check vhost_user_write() return value
Date: Fri, 24 Jun 2016 14:49:22 +0200


On Thu, Jun 23, 2016 at 7:08 PM, Michael S. Tsirkin <address@hidden> wrote:
>> Callers do not always ignore it (and in general it should not, should it?), 
>> this helps breaking the execution at right moment, help debugging, code 
>> consistency, good practices etc (perhaps it's too obvious to me and I am 
>> missing something?)
> Reporting error up the stack is helpful if it's handled in some way.
> If we just keep guest going on this error, then we could
> maybe log it for debug build but that's all.

Reporting up to guest somehow would be a good thing at some point, so
I think we should start from the bottom. vhost-user lacks error
handling, let's add it.

Regarding debug build messages, I don't think it's enough. As long as
we don't have an official supported way to handle disconnect. It's
better to report an error than be silent.

Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]