[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 01/14] nbd: Fix bad flag detection on server
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v4 01/14] nbd: Fix bad flag detection on server |
Date: |
Sat, 25 Jun 2016 16:15:41 -0600 |
Commit ab7c548e added a check for invalid flags, but used an
early return on error instead of properly going through the
cleanup label.
Signed-off-by: Eric Blake <address@hidden>
---
v4: new patch
---
nbd/server.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/nbd/server.c b/nbd/server.c
index 2f2d9dd..724ac12 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -1057,7 +1057,8 @@ static ssize_t nbd_co_receive_request(NBDRequest *req,
if (request->type & ~NBD_CMD_MASK_COMMAND & ~NBD_CMD_FLAG_FUA) {
LOG("unsupported flags (got 0x%x)",
request->type & ~NBD_CMD_MASK_COMMAND);
- return -EINVAL;
+ rc = -EINVAL;
+ goto out;
}
rc = 0;
--
2.5.5
- [Qemu-devel] [PATCH v4 00/14] nbd: efficient write zeroes, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 01/14] nbd: Fix bad flag detection on server,
Eric Blake <=
- [Qemu-devel] [PATCH v4 09/14] nbd: Let client skip portions of server reply, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 06/14] nbd: Send message along with server NBD_REP_ERR errors, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 11/14] nbd: Support shorter handshake, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 04/14] nbd: Treat flags vs. command type as separate fields, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on client, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 07/14] nbd: Share common option-sending code in client, Eric Blake, 2016/06/25
- [Qemu-devel] [PATCH v4 05/14] nbd: Share common reply-sending code in server, Eric Blake, 2016/06/25