Re: [Qemu-devel] [PATCH 00/13] virtio migration: Flip outer layer to vmstate

[Dr. David Alan Gilbert]

* Amit Shah (address@hidden) wrote:
> On (Tue) 21 Jun 2016 [20:13:54], Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > Hi,
> >   This series converts the outer most layer of virtio to
> > use VMState macros;  this is the easy bit, but I'm hoping that
> > having done that, the next trick is to nibble away at the virtio_save/load
> > functions and all of the zillions of device/bus helpers.
> 
> I'm not sure how to go about this though - should we pick these
> patches now, and keep taking smaller stabs at the problem; vs
> maintaining a separate tree and see how the series grows and what
> directions it takes.

My intention was that this set would be taken as is and then we'd do some
more later.  Killing off register_savevm will probably take another
couple of dozen patches all over the place.  Turning all of virtio
into VMState will probably take a lot more.

> > I think the first two patches are the most controversial;
> > they remove migration support for old version of virtio-net and 
> > virtio-serial;
> > (for virtio-net versions prior to 0.11 and for virtio-serial prior to 0.13).
> > I'm working on the basis that migration has bit rotted enough so
> > that the streams aren't migration compatible for that long back
> > on upstream - but if anyone knows otherwise please shout.
> 
> I think it's fine to remove these.  Distributions that depend on older
> releases should take the burden of maintaining the older state.
> However, as you say, it could be controversial, so let's wait for more
> input from others.

Dave

> 
> 
>               Amit
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK