[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 11/30] target-i386: add atomic helpers

From: Richard Henderson
Subject: Re: [Qemu-devel] [RFC 11/30] target-i386: add atomic helpers
Date: Mon, 27 Jun 2016 13:27:35 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1

On 06/27/2016 12:01 PM, Emilio G. Cota wrote:
This patch only adds the helpers. Functions to invoke the helpers
from translated code are generated in subsequent patches.

Signed-off-by: Emilio G. Cota <address@hidden>
 target-i386/helper.h     | 34 ++++++++++++++++++++++++++++++++++
 target-i386/mem_helper.c | 38 ++++++++++++++++++++++++++++++++++++++
 target-i386/translate.c  | 45 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 117 insertions(+)

These are bare wrappers around what you've just added to exec/cpu_ldst*.

(1) Is there any reason these shouldn't go into tcg-runtime.h and tcg-runtime.c instead?

(2) If so, is there any good reason to add these to cpu_ldst* instead of *only* adding them as helpers to tcg-runtime.c?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]