qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/17] s390x/pci: introduce S390PCIBusDevice qde


From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH 09/17] s390x/pci: introduce S390PCIBusDevice qdev
Date: Tue, 28 Jun 2016 18:43:05 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 06/28/2016 06:21 PM, Cornelia Huck wrote:
On Tue, 28 Jun 2016 17:49:18 +0300
Marcel Apfelbaum <address@hidden> wrote:

On 06/24/2016 04:28 PM, Cornelia Huck wrote:
From: Yi Min Zhao <address@hidden>

+static const TypeInfo s390_pci_device_info = {
+    .name = TYPE_S390_PCI_DEVICE,
+    .parent = TYPE_DEVICE,

Hi,

Here we have the same mismatch.  TYPE_S390_PCI_DEVICE does not derive
from TYPE_PCI_DEVICE. If I understand correctly the "zpci device"
is a wrapper to the actual PCI device, maybe the name can reflect it.

TYPE_S390PCI_DEVICE?


The same as on prev discussion, maybe TYPE_ZPCI_DEVICE, but is not *that* 
important.

Thanks,
Marcel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]