[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 02/11] qemu-clk: allow to attach a clock to
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [RFC PATCH 02/11] qemu-clk: allow to attach a clock to a device |
Date: |
Tue, 28 Jun 2016 17:15:13 -0700 |
On Mon, Jun 13, 2016 at 9:27 AM, <address@hidden> wrote:
> From: KONRAD Frederic <address@hidden>
>
> This allows to attach a clock to a DeviceState.
> Contrary to gpios, the clock pins are not contained in the DeviceState but
> with the child property so they can appears in the qom-tree.
>
> Signed-off-by: KONRAD Frederic <address@hidden>
> ---
> include/qemu/qemu-clock.h | 24 +++++++++++++++++++++++-
> qemu-clock.c | 22 ++++++++++++++++++++++
> 2 files changed, 45 insertions(+), 1 deletion(-)
>
> diff --git a/include/qemu/qemu-clock.h b/include/qemu/qemu-clock.h
> index e7acd68..a2ba105 100644
> --- a/include/qemu/qemu-clock.h
> +++ b/include/qemu/qemu-clock.h
> @@ -33,8 +33,30 @@
> typedef struct qemu_clk {
> /*< private >*/
> Object parent_obj;
> + char *name; /* name of this clock in the device. */
> } *qemu_clk;
>
> -#endif /* QEMU_CLOCK_H */
> +/**
> + * qemu_clk_attach_to_device:
> + * @d: the device on which the clock need to be attached.
> + * @clk: the clock which need to be attached.
> + * @name: the name of the clock can't be NULL.
> + *
> + * Attach @clk named @name to the device @d.
> + *
> + */
> +void qemu_clk_attach_to_device(DeviceState *d, qemu_clk clk,
dev instead of just d
> + const char *name);
>
> +/**
> + * qemu_clk_get_pin:
> + * @d: the device which contain the clock.
> + * @name: the name of the clock.
> + *
> + * Get the clock named @name located in the device @d, or NULL if not found.
> + *
> + * Returns the clock named @name contained in @d.
> + */
> +qemu_clk qemu_clk_get_pin(DeviceState *d, const char *name);
>
> +#endif /* QEMU_CLOCK_H */
> diff --git a/qemu-clock.c b/qemu-clock.c
> index 4a47fb4..81f2852 100644
> --- a/qemu-clock.c
> +++ b/qemu-clock.c
> @@ -23,6 +23,7 @@
>
> #include "qemu/qemu-clock.h"
> #include "hw/hw.h"
> +#include "qapi/error.h"
>
> /* #define DEBUG_QEMU_CLOCK */
>
> @@ -33,6 +34,27 @@ do { printf("qemu-clock: " fmt , ## __VA_ARGS__); } while
> (0)
> #define DPRINTF(fmt, ...) do { } while (0)
> #endif
>
> +void qemu_clk_attach_to_device(DeviceState *d, qemu_clk clk, const char
> *name)
> +{
> + assert(name);
> + assert(!clk->name);
> + object_property_add_child(OBJECT(d), name, OBJECT(clk), &error_abort);
> + clk->name = g_strdup(name);
> +}
> +
> +qemu_clk qemu_clk_get_pin(DeviceState *d, const char *name)
> +{
> + gchar *path = NULL;
> + Object *clk;
> + bool ambiguous;
> +
> + path = g_strdup_printf("%s/%s", object_get_canonical_path(OBJECT(d)),
> + name);
> + clk = object_resolve_path(path, &ambiguous);
Should ambiguous be passed back to the caller?
> + g_free(path);
> + return QEMU_CLOCK(clk);
Shouldn't you check to see if you got something valid before casting?
Thanks,
Alistair
> +}
> +
> static const TypeInfo qemu_clk_info = {
> .name = TYPE_CLOCK,
> .parent = TYPE_OBJECT,
> --
> 2.5.5
>
>
- [Qemu-devel] [RFC PATCH 00/11] Clock framework API., fred . konrad, 2016/06/13
- [Qemu-devel] [RFC PATCH 01/11] qemu-clk: introduce qemu-clk qom object, fred . konrad, 2016/06/13
- [Qemu-devel] [RFC PATCH 06/11] introduce fixed-clock, fred . konrad, 2016/06/13
- [Qemu-devel] [RFC PATCH 04/11] qdev-monitor: print the device's clock with info qtree, fred . konrad, 2016/06/13
- [Qemu-devel] [RFC PATCH 05/11] docs: add qemu-clock documentation, fred . konrad, 2016/06/13
- [Qemu-devel] [RFC PATCH 02/11] qemu-clk: allow to attach a clock to a device, fred . konrad, 2016/06/13
- Re: [Qemu-devel] [RFC PATCH 02/11] qemu-clk: allow to attach a clock to a device,
Alistair Francis <=
- [Qemu-devel] [RFC PATCH 08/11] zynqmp_crf: fix against AF_EX32 changes, fred . konrad, 2016/06/13
- [Qemu-devel] [RFC PATCH 07/11] introduce zynqmp_crf, fred . konrad, 2016/06/13
- [Qemu-devel] [RFC PATCH 03/11] qemu-clk: allow to bound two clocks together, fred . konrad, 2016/06/13
- [Qemu-devel] [RFC PATCH 10/11] zynqmp: add the zynqmp_crf to the platform, fred . konrad, 2016/06/13
- [Qemu-devel] [RFC PATCH 09/11] zynqmp_crf: add the clock mechanism, fred . konrad, 2016/06/13
- [Qemu-devel] [RFC PATCH 11/11] zynqmp: add reference clock, fred . konrad, 2016/06/13