[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] blockjob: assert(cb) when create job
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] blockjob: assert(cb) when create job |
Date: |
Tue, 28 Jun 2016 22:56:37 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Jun 23, 2016 at 04:57:20PM +0800, Changlong Xie wrote:
> Callback for block job should always exist
>
> Suggested-by: Paolo Bonzini <address@hidden>
> Suggested-by: Kevin Wolf <address@hidden>
> Signed-off-by: Changlong Xie <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
> ---
> block/backup.c | 1 -
> blockjob.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/backup.c b/block/backup.c
> index 581269b..f87f8d5 100644
> --- a/block/backup.c
> +++ b/block/backup.c
> @@ -489,7 +489,6 @@ void backup_start(BlockDriverState *bs, BlockDriverState
> *target,
>
> assert(bs);
> assert(target);
> - assert(cb);
>
> if (bs == target) {
> error_setg(errp, "Source and target cannot be the same");
> diff --git a/blockjob.c b/blockjob.c
> index 90c4e26..205da9d 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -110,6 +110,7 @@ void *block_job_create(const BlockJobDriver *driver,
> BlockDriverState *bs,
> BlockBackend *blk;
> BlockJob *job;
>
> + assert(cb);
> if (bs->job) {
> error_setg(errp, QERR_DEVICE_IN_USE, bdrv_get_device_name(bs));
> return NULL;
> --
> 1.9.3
>
>
>
- [Qemu-devel] [PATCH v2 0/2] small fix of block job, Changlong Xie, 2016/06/23
- [Qemu-devel] [PATCH v2 1/2] blockjob: assert(cb) when create job, Changlong Xie, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 1/2] blockjob: assert(cb) when create job,
Jeff Cody <=
- [Qemu-devel] [PATCH v2 2/2] mirror: fix misleading comments, Changlong Xie, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 0/2] small fix of block job, Fam Zheng, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 0/2] small fix of block job, Stefan Hajnoczi, 2016/06/24
- Re: [Qemu-devel] [PATCH v2 0/2] small fix of block job, Jeff Cody, 2016/06/28