[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 1/8] spapr: drop reference on child object during co

From: Greg Kurz
Subject: [Qemu-devel] [PATCH 1/8] spapr: drop reference on child object during core realization
Date: Wed, 29 Jun 2016 22:50:20 +0200
User-agent: StGit/0.17.1-dirty

When a core is being realized, we create a child object for each thread
of the core.

The child is first initialized with object_initialize() which sets its ref
count to 1, and then added to the core with object_property_add_child()
which bumps the ref count to 2.

When the core gets released, object_unparent() decreases the ref count to 1,
and we g_free() the object: we hence loose the reference on an unfinalized
object. This is likely to cause random crashes.

Let's drop the extra reference as soon as we don't need it, after the
thread is added to the core.

Signed-off-by: Greg Kurz <address@hidden>
 hw/ppc/spapr_cpu_core.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
index 2aa0dc523374..789eb2e6f206 100644
--- a/hw/ppc/spapr_cpu_core.c
+++ b/hw/ppc/spapr_cpu_core.c
@@ -299,8 +299,9 @@ static void spapr_cpu_core_realize(DeviceState *dev, Error 
         object_property_add_child(OBJECT(sc), id, obj, &local_err);
         if (local_err) {
             goto err;
+        object_unref(obj);
     object_child_foreach(OBJECT(dev), spapr_cpu_core_realize_child, 
     if (local_err) {
         goto err;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]