[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL v2 1/7] json-streamer: Don't leak tokens on incomplet

From: Markus Armbruster
Subject: [Qemu-devel] [PULL v2 1/7] json-streamer: Don't leak tokens on incomplete parse
Date: Thu, 30 Jun 2016 15:42:45 +0200

From: Eric Blake <address@hidden>

Valgrind complained about a number of leaks in

==12657==    definitely lost: 17,247 bytes in 1,234 blocks

All of which had the same root cause: on an incomplete parse,
we were abandoning the token queue without cleaning up the
allocated data within each queue element.  Introduced in
commit 95385fe, when we switched from QList (which recursively
frees contents) to g_queue (which does not).

We don't yet require glib 2.32 with its g_queue_free_full(),
so open-code it instead.

CC: address@hidden
Signed-off-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
 qobject/json-streamer.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/qobject/json-streamer.c b/qobject/json-streamer.c
index 0251685..7164390 100644
--- a/qobject/json-streamer.c
+++ b/qobject/json-streamer.c
@@ -20,9 +20,15 @@
 #define MAX_TOKEN_COUNT (2ULL << 20)
 #define MAX_NESTING (1ULL << 10)
+static void json_message_free_token(void *token, void *opaque)
+    g_free(token);
 static void json_message_free_tokens(JSONMessageParser *parser)
     if (parser->tokens) {
+        g_queue_foreach(parser->tokens, json_message_free_token, NULL);
         parser->tokens = NULL;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]