qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] balloon: Fix failure of updating guest memory s


From: Li, Liang Z
Subject: Re: [Qemu-devel] [PATCH] balloon: Fix failure of updating guest memory status
Date: Thu, 30 Jun 2016 16:58:28 +0000

> > +    if (s->stats_vq_elem == NULL) {
> > +        virtqueue_push(s->svq, &elem, 0);
> > +        virtio_notify(vdev, s->svq);
> > +        return;
> > +    }
> >      virtqueue_push(s->svq, s->stats_vq_elem, s->stats_vq_offset);
> >      virtio_notify(vdev, s->svq);
> >      g_free(s->stats_vq_elem);
> >
> 
> Hi, the right fix is to migrate s->stats_vq_elem if it is not NULL.  See how 
> it's
> done in hw/char/virtio-serial.c's virtio_serial_save_device
> (save) and fetch_active_ports_list (load).
> 
> Paolo

Thanks for your information, it's very helpful. I will send the v2.

Liang


reply via email to

[Prev in Thread] Current Thread [Next in Thread]