[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] pcspk: fix KVM
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] pcspk: fix KVM |
Date: |
Thu, 30 Jun 2016 19:26:36 +0100 |
On 30 June 2016 at 15:57, Paolo Bonzini <address@hidden> wrote:
> The link property that was added to the pcspk device has the wrong type:
> it is only correct for TCG and for KVM's userspace or split irqchip
> options. The default KVM option (fully in-kernel irqchip) breaks
> because it uses a PIT whose type is a sibling of TYPE_I8254.
>
> Fixes: 873b4d3f0571a1e415cf089a67a230ea8a12d059
> Tested-by: Peter Lieven <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/audio/pcspk.c | 2 +-
> include/hw/timer/i8254.h | 8 ++++++++
> include/hw/timer/i8254_internal.h | 8 --------
> 3 files changed, 9 insertions(+), 9 deletions(-)
reviewed and applied to master, thanks.
-- PMM