Re: [Qemu-devel] [PATCH v2 16/18] target-i386: fix apic object leak when CPU is deleted

[Igor Mammedov]

On Mon, 4 Jul 2016 17:19:33 +0300
"Michael S. Tsirkin" <address@hidden> wrote:

> On Fri, Jun 24, 2016 at 06:06:04PM +0200, Igor Mammedov wrote:
> > Signed-off-by: Igor Mammedov <address@hidden>
> 
> Can this bugfix be extracted from series?
It's possible but there isn't much point as leak happens on CPU removal
and its harmful only with cpu-hotunplug which this series enables.
 
> > ---
> >  target-i386/cpu.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> > index 04c0b79..2fa445d 100644
> > --- a/target-i386/cpu.c
> > +++ b/target-i386/cpu.c
> > @@ -2765,6 +2765,7 @@ static void x86_cpu_apic_create(X86CPU *cpu,
> > Error **errp) 
> >      object_property_add_child(OBJECT(cpu), "lapic",
> >                                OBJECT(cpu->apic_state),
> > &error_abort);
> > +    object_unref(OBJECT(cpu->apic_state));
> >  
> >      qdev_prop_set_uint8(cpu->apic_state, "id", cpu->apic_id);
> >      /* TODO: convert to link<> */
> > -- 
> > 1.8.3.1