[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 03/26] x86-iommu: q35: generalize find_add_a
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v10 03/26] x86-iommu: q35: generalize find_add_as() |
|
Date: |
Mon, 4 Jul 2016 18:40:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 04/07/2016 18:35, Michael S. Tsirkin wrote:
>> >
>> > Not sure what you mean. Each IOMMU subclass can define its own
>> > find_add_as implementation, what's wrong with that?
>> >
>> > Paolo
>
> this:
>
> @@ -2060,6 +2060,7 @@ static void vtd_class_init(ObjectClass *klass, void
> *data)
> dc->vmsd = &vtd_vmstate;
> dc->props = vtd_properties;
> x86_class->realize = vtd_realize;
> + x86_class->find_add_as = vtd_find_add_as;
> }
>
> I think this
> means that if there are two classes inheriting x86_class,
> they will conflict over-writing vtd_find_add_as in the
> parent.
No, x86_class is really just (X86IOMMUClass *)klass, and klass is local.
Paolo