|
From: | Cao jin |
Subject: | Re: [Qemu-devel] [PATCH] main-loop: check return value before using |
Date: | Wed, 6 Jul 2016 15:46:14 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 07/06/2016 02:46 PM, Fam Zheng wrote:
On Wed, 07/06 11:03, Cao jin wrote:pointer 'qemu_aio_context' should be checked first before it is used. qemu_bh_new() will use it. Also add extra newlines to make code well separated and easier to read.This "also" is not good, please only do one thing in a patch. Fam
Thanks Fam. See what I was told before when come to here: http://lists.nongnu.org/archive/html/qemu-trivial/2015-10/msg00116.html http://lists.nongnu.org/archive/html/qemu-trivial/2015-10/msg00123.htmlSo since then, I always prefer to squeeze stylistics patch into a productive one.
Ok, I will split it. Yours Sincerely, Cao jin
[Prev in Thread] | Current Thread | [Next in Thread] |