[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 6/6] block: Remove BB options from blockdev-add
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH v3 6/6] block: Remove BB options from blockdev-add |
Date: |
Wed, 6 Jul 2016 16:45:09 +0200 |
werror/rerror are now available as qdev options. The stats-* options are
removed without an existing replacement; they should probably be
configurable with a separate QMP command like I/O throttling settings.
Removing id is left for another day because this involves updating
qemu-iotests cases to use node-name for everything. Before we can do
that, however, all QMP commands must support node-name.
Signed-off-by: Kevin Wolf <address@hidden>
---
qapi/block-core.json | 18 +-----------------
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 6008986..88b78a7 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2051,20 +2051,8 @@
# @discard: #optional discard-related options (default: ignore)
# @cache: #optional cache-related options
# @aio: #optional AIO backend (default: threads)
-# @rerror: #optional how to handle read errors on the device
-# (default: report)
-# @werror: #optional how to handle write errors on the device
-# (default: enospc)
# @read-only: #optional whether the block device should be read-only
# (default: false)
-# @stats-account-invalid: #optional whether to include invalid
-# operations when computing last access statistics
-# (default: true) (Since 2.5)
-# @stats-account-failed: #optional whether to include failed
-# operations when computing latency and last
-# access statistics (default: true) (Since 2.5)
-# @stats-intervals: #optional list of intervals for collecting I/O
-# statistics, in seconds (default: none) (Since 2.5)
# @detect-zeroes: #optional detect and optimize zero writes (Since 2.1)
# (default: off)
#
@@ -2074,17 +2062,13 @@
##
{ 'union': 'BlockdevOptions',
'base': { 'driver': 'BlockdevDriver',
+# TODO 'id' is a BB-level option, remove it
'*id': 'str',
'*node-name': 'str',
'*discard': 'BlockdevDiscardOptions',
'*cache': 'BlockdevCacheOptions',
'*aio': 'BlockdevAioOptions',
- '*rerror': 'BlockdevOnError',
- '*werror': 'BlockdevOnError',
'*read-only': 'bool',
- '*stats-account-invalid': 'bool',
- '*stats-account-failed': 'bool',
- '*stats-intervals': ['int'],
'*detect-zeroes': 'BlockdevDetectZeroesOptions' },
'discriminator': 'driver',
'data': {
--
1.8.3.1
- [Qemu-devel] [PATCH v3 0/6] block: Move BB options from blockdev-add to qdev, Kevin Wolf, 2016/07/06
- [Qemu-devel] [PATCH v3 3/6] commit: Fix use of error handling policy, Kevin Wolf, 2016/07/06
- [Qemu-devel] [PATCH v3 5/6] qemu-iotests: Test setting WCE with qdev, Kevin Wolf, 2016/07/06
- [Qemu-devel] [PATCH v3 1/6] block/qdev: Allow node name for drive properties, Kevin Wolf, 2016/07/06
- [Qemu-devel] [PATCH v3 6/6] block: Remove BB options from blockdev-add,
Kevin Wolf <=
- [Qemu-devel] [PATCH v3 4/6] block/qdev: Allow configuring rerror/werror with qdev properties, Kevin Wolf, 2016/07/06
- [Qemu-devel] [PATCH v3 2/6] block/qdev: Allow configuring WCE with qdev properties, Kevin Wolf, 2016/07/06
- Re: [Qemu-devel] [PATCH v3 0/6] block: Move BB options from blockdev-add to qdev, Kevin Wolf, 2016/07/08