[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/6] hw/block/m25p80: fix resource leak
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 5/6] hw/block/m25p80: fix resource leak |
Date: |
Thu, 7 Jul 2016 14:48:56 +0100 |
From: Shannon Zhao <address@hidden>
These two are spot by Coverity 1357232 and 1357233.
Signed-off-by: Shannon Zhao <address@hidden>
Message-id: address@hidden
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
hw/block/m25p80.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index d9b2793..ca8c12c 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -459,12 +459,13 @@ static void blk_sync_complete(void *opaque, int ret)
static void flash_sync_page(Flash *s, int page)
{
- QEMUIOVector *iov = g_new(QEMUIOVector, 1);
+ QEMUIOVector *iov;
if (!s->blk || blk_is_read_only(s->blk)) {
return;
}
+ iov = g_new(QEMUIOVector, 1);
qemu_iovec_init(iov, 1);
qemu_iovec_add(iov, s->storage + page * s->pi->page_size,
s->pi->page_size);
@@ -474,13 +475,14 @@ static void flash_sync_page(Flash *s, int page)
static inline void flash_sync_area(Flash *s, int64_t off, int64_t len)
{
- QEMUIOVector *iov = g_new(QEMUIOVector, 1);
+ QEMUIOVector *iov;
if (!s->blk || blk_is_read_only(s->blk)) {
return;
}
assert(!(len % BDRV_SECTOR_SIZE));
+ iov = g_new(QEMUIOVector, 1);
qemu_iovec_init(iov, 1);
qemu_iovec_add(iov, s->storage + off, len);
blk_aio_pwritev(s->blk, off, iov, 0, blk_sync_complete, iov);
--
1.9.1
- [Qemu-devel] [PULL 0/6] target-arm queue, Peter Maydell, 2016/07/07
- [Qemu-devel] [PULL 3/6] aux: fix break that wanted to break two levels out, Peter Maydell, 2016/07/07
- [Qemu-devel] [PULL 5/6] hw/block/m25p80: fix resource leak,
Peter Maydell <=
- [Qemu-devel] [PULL 1/6] target-arm/arm-semi.c: In SYS_HEAPINFO use correct type for 'limit', Peter Maydell, 2016/07/07
- [Qemu-devel] [PULL 2/6] xlnx_dp: fix iffy xlnx_dp_aux_push_tx_fifo, Peter Maydell, 2016/07/07
- [Qemu-devel] [PULL 6/6] i.MX: split the GPT timer implementation into per SOC definitions, Peter Maydell, 2016/07/07
- [Qemu-devel] [PULL 4/6] aux: Rename aux.[ch] to auxbus.[ch] for the benefit of Windows, Peter Maydell, 2016/07/07
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Peter Maydell, 2016/07/11