[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through qom |
|
Date: |
Thu, 7 Jul 2016 13:44:48 -0300 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
Hi,
Sorry for taking so long to review it.
The patch in general looks good, except for:
On Fri, Jun 24, 2016 at 01:49:36PM +0300, Denis V. Lunev wrote:
[...]
> + if (MACHINE_GET_CLASS(current_machine)->hot_add_cpu != NULL) {
> + env->features[FEAT_HYPERV_EDX] |=
> HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE;
> + }
[...]
> +}
> +
[...]
> - c->edx |= HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE;
If you want to change the rules for setting
HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE, please do it in a
separate patch.
--
Eduardo