Re: [Qemu-devel] [PATCH v3 0/5] Support building qemu-user powered docker test images

[Alex Bennée]

Fam Zheng <address@hidden> writes:

> On Tue, 06/28 16:42, Alex Bennée wrote:
>> This is the latest iteration of my qemu-user support inside Docker.
>> They apply directly on top of master. I've made the changes suggested
>> in the last review and split apart another patch. I've also added a
>> new update command so a tagged image can be updated with the latest
>> QEMU.
>>
>> To use, first ensure you build the debian-bootstrap image:
>>
>>     DEB_ARCH=armhf DEB_TYPE=testing \
>>       ./tests/docker/docker.py build qemu:debian-bootstrap \
>>       ./tests/docker/dockerfiles/debian-bootstrap.docker \
>>       --include-executable=./arm-linux-user/qemu-arm
>
> Alex,
>
> Sorry for the late reply.
>
> Is there a way to setup or detect the binfmt_misc configuration on the
> system?

The trick is doing this in a distribution agnostic way. Certainly
Debian-a-like systems have scripts that allow you to query the state of
binmfmt_misc.

> I think it's better to error out (and hint how to fix that) if qemu-arm is not
> registered. Now it only fails complaining about "wrong exec format" after the
> long debootstrap process is done.

Would it be enough to warn if basename of the included executable
doesn't appear anywhere in binfmt_misc?

>
> Fam
>
>>
>> And then run the test quick target:
>>
>>     make address@hidden J=9 V=1
>>
>> To update the installed QEMU:
>>
>>     ./tests/docker/docker.py update qemu:debian-bootstrap \
>>       ./arm-linux-user/qemu-arm
>>
>> To run a throwaway container:
>>
>>     docker run -t -i --rm qemu:debian-bootstrap
>>
>> I'll leave it up to you how we cleanly integrate multi-arch builds
>> into the Make system ;-)
>>
>> Alex Bennée (5):
>>   tests/docker/docker.py: docker_dir outside build
>>   tests/docker/docker.py: support --include-executable
>>   tests/docker/docker.py: check and run .pre script
>>   tests/docker/dockerfiles: new debian-bootstrap.docker
>>   tests/docker/docker.py: add update operation
>>
>>  tests/docker/docker.py                           | 144 
>> +++++++++++++++++++++--
>>  tests/docker/dockerfiles/debian-bootstrap.docker |  21 ++++
>>  tests/docker/dockerfiles/debian-bootstrap.pre    |   5 +
>>  3 files changed, 161 insertions(+), 9 deletions(-)
>>  create mode 100644 tests/docker/dockerfiles/debian-bootstrap.docker
>>  create mode 100755 tests/docker/dockerfiles/debian-bootstrap.pre
>>
>> --
>> 2.7.4
>>


--
Alex Bennée