[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] target-arm: Fix unreachable code in gicv3_class_nam

From: Peter Maydell
Subject: [Qemu-devel] [PATCH] target-arm: Fix unreachable code in gicv3_class_name()
Date: Mon, 11 Jul 2016 19:09:12 +0100

Coverity complains that the exit() in gicv3_class_name()
can be unreachable, because if TARGET_AARCH64 is defined
then all code paths return before reaching it. Move the
exit() up to the error_report() that it belongs with.

Signed-off-by: Peter Maydell <address@hidden>
 target-arm/machine.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target-arm/machine.c b/target-arm/machine.c
index 2dbeb82..7a6ca31 100644
--- a/target-arm/machine.c
+++ b/target-arm/machine.c
@@ -340,10 +340,9 @@ const char *gicv3_class_name(void)
         error_report("KVM GICv3 acceleration is not supported on this "
+        exit(1);
     } else {
         return "arm-gicv3";
-    exit(1);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]