Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS

[Eric Blake]

On 07/13/2016 01:57 AM, Roman Pen wrote:
> v1..v2:
> 
>   o comment tweaks.
>   o fix QEMU coding style.

The above comments should be delayed...

> 
> Invoking io_setup(MAX_EVENTS) we ask kernel to create ring buffer for us
> with specified number of events.  But kernel ring buffer allocation logic
> is a bit tricky (ring buffer is page size aligned + some percpu allocation
> are required) so eventually more than requested events number is allocated.
> 

...

> Signed-off-by: Roman Pen <address@hidden>
> Reviewed-by: Fam Zheng <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: address@hidden
> ---

...until here, after the --- separator.  They are useful to reviewers,
but won't make much sense a year from now in qemu.git (when we don't
care what other versions were on list, only the version that got committed).

Also, if you use 'git send-email -v2' (or 'git format-patch -v2'), your
subject line will resemble most other versioned patches (which use
[PATCH v2] rather than [PATCH V2]).  We also recommend that v2 patches
be sent as top-level threads, rather than in-reply to v1.

More submission hints at http://wiki.qemu.org/Contribute/SubmitAPatch

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature