[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 04/11] block: Accept node-name for blockdev-mirro
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH v4 04/11] block: Accept node-name for blockdev-mirror |
Date: |
Thu, 14 Jul 2016 15:28:07 +0200 |
In order to remove the necessity to use BlockBackend names in the
external API, we want to allow node-names everywhere. This converts
blockdev-mirror to accept a node-name without lifting the restriction
that we're operating at a root node.
Signed-off-by: Kevin Wolf <address@hidden>
---
blockdev.c | 10 +---------
qapi/block-core.json | 3 ++-
qmp-commands.hx | 3 ++-
3 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index e5a5642..7701f73 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3663,21 +3663,13 @@ void qmp_blockdev_mirror(bool has_job_id, const char
*job_id,
Error **errp)
{
BlockDriverState *bs;
- BlockBackend *blk;
BlockDriverState *target_bs;
AioContext *aio_context;
BlockMirrorBackingMode backing_mode = MIRROR_LEAVE_BACKING_CHAIN;
Error *local_err = NULL;
- blk = blk_by_name(device);
- if (!blk) {
- error_setg(errp, "Device '%s' not found", device);
- return;
- }
- bs = blk_bs(blk);
-
+ bs = qmp_get_root_bs(device, errp);
if (!bs) {
- error_setg(errp, "Device '%s' has no media", device);
return;
}
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 728b5f7..6266748 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1261,7 +1261,8 @@
# @job-id: #optional identifier for the newly-created block job. If
# omitted, the device name will be used. (Since 2.7)
#
-# @device: the name of the device whose writes should be mirrored.
+# @device: The device name or node-name of a root node whose writes should be
+# mirrored.
#
# @target: the id or node-name of the block device to mirror to. This mustn't
be
# attached to guest.
diff --git a/qmp-commands.hx b/qmp-commands.hx
index e7608f2..4f6a474 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1747,7 +1747,8 @@ Arguments:
- "job-id": Identifier for the newly-created block job. If omitted,
the device name will be used. (json-string, optional)
-- "device": device name to operate on (json-string)
+- "device": The device name or node-name of a root node whose writes should be
+ mirrored (json-string)
- "target": device name to mirror to (json-string)
- "replaces": the block driver node name to replace when finished
(json-string, optional)
--
1.8.3.1
- [Qemu-devel] [PATCH v4 00/11] block: Accept node-name in all node level QMP commands, Kevin Wolf, 2016/07/14
- [Qemu-devel] [PATCH v4 04/11] block: Accept node-name for blockdev-mirror,
Kevin Wolf <=
- [Qemu-devel] [PATCH v4 03/11] block: Accept node-name for blockdev-backup, Kevin Wolf, 2016/07/14
- [Qemu-devel] [PATCH v4 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync, Kevin Wolf, 2016/07/14
- [Qemu-devel] [PATCH v4 07/11] block: Accept node-name for change-backing-file, Kevin Wolf, 2016/07/14
- [Qemu-devel] [PATCH v4 08/11] block: Accept node-name for drive-backup, Kevin Wolf, 2016/07/14