[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 5/6] tests: removed skipped flushes from bloc
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 5/6] tests: removed skipped flushes from block test traces |
Date: |
Thu, 14 Jul 2016 10:06:39 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/14/2016 06:29 AM, Denis V. Lunev wrote:
> From: Evgeny Yakovlev <address@hidden>
>
> bdrv_co_flush is now skipping flushes in case underlying media has no
> actual changes. This affected some blkdebug testcases that were
> expecting error logs from failure-injected flushes which are now
> skipped entirely.
>
> This change removes expected flush error logs from block tests 026 071 089
>
> Signed-off-by: Evgeny Yakovlev <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Fam Zheng <address@hidden>
> CC: John Snow <address@hidden>
> ---
> tests/qemu-iotests/026.out.nocache | 50
> --------------------------------------
> tests/qemu-iotests/071.out | 8 ------
> tests/qemu-iotests/089.out | 2 --
> 3 files changed, 60 deletions(-)
If the previous patch broke the testsuite, then this should be squashed
in with that patch so that bisection doesn't land on a broken testsuite.
Seeing the testsuite change alongside code change is just fine; it
proves what impact the code change has.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 0/6] block: ignore flush requests when storage is clean, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v6 6/6] tests: changed block job ready event generation order, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v6 5/6] tests: removed skipped flushes from block test traces, Denis V. Lunev, 2016/07/14
- Re: [Qemu-devel] [PATCH v6 5/6] tests: removed skipped flushes from block test traces,
Eric Blake <=
- [Qemu-devel] [PATCH v6 1/6] ide: refactor retry_unit set and clear into separate function, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v6 2/6] ide: set retry_unit for PIO and FLUSH requests, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v6 4/6] block: ignore flush requests when storage is clean, Denis V. Lunev, 2016/07/14
- [Qemu-devel] [PATCH v6 3/6] tests: in IDE and AHCI tests perform DMA write before flushing, Denis V. Lunev, 2016/07/14