[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include stat
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include statement |
|
Date: |
Thu, 14 Jul 2016 18:32:43 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 07/14/2016 02:14 AM, Thomas Huth wrote:
>> No need to include error-report.h twice here.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>> target-ppc/mmu-hash64.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> Markus, do your header cleanup scripts detect any other situations like
> this?
Not yet.
Here's how I'd eliminate double inclusion. Step 1: make our own headers
includable in any order. Step 2: include them in alphabetical order.
The duplicates become obvious, and get dropped. Step 3: tell the lazy
bums adding includes in the wrong place to mend their ways.
I'm knee-deep in step 1.