Re: [Qemu-devel] [PATCH 0/8] nvdimm: hotplug support

[Xiao Guangrong]

On 07/14/2016 08:17 PM, Stefan Hajnoczi wrote:
> On Mon, Jul 11, 2016 at 09:45:10PM +0800, Xiao Guangrong wrote:
> > This patchset is against commit 269fe4c3ab0c (vmw_pvscsi: remove unnecessary
> > internal msi state flag) on pci branch of Michael's git tree and can be found
> > at:
> >        https://github.com/xiaogr/qemu.git nvdimm-hotplug-v1
> >
> > This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug,
> > for example, a new nvdimm device can be plugged as follows:
> > object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3
> > device_add nvdimm,id=nvdimm3,memdev=mem3
> >
> > and unplug it as follows:
> > device_del nvdimm3
> > object_del mem3
> >
> > Xiao Guangrong (8):
> >    acpi nvdimm: fix wrong buffer size returned by DSM method
> >    nvdimm acpi: prebuild nvdimm devices for available slots
> >    nvdimm acpi: introduce _FIT
> >    nvdimm acpi: implement Read FIT function
> >    pc-dimm: introduce prepare_unplug() callback
> >    pc: memhp: do not export nvdimm's memory via _CRS
> >    pc: acpi: memhp: nvdimm hotplug support
> >    nvdimm docs: add nvdimm Read FIT function
> >
> >   docs/specs/acpi_mem_hotplug.txt  |   4 +-
> >   docs/specs/acpi_nvdimm.txt       |  38 +++++++-
> >   hw/acpi/ich9.c                   |   3 +
> >   hw/acpi/memory_hotplug.c         |  21 +++--
> >   hw/acpi/nvdimm.c                 | 195 +++++++++++++++++++++++++++++++++++----
> >   hw/acpi/piix4.c                  |   3 +
> >   hw/i386/acpi-build.c             |  28 +++++-
> >   hw/mem/nvdimm.c                  |  12 ++-
> >   hw/mem/pc-dimm.c                 |   5 +
> >   include/hw/acpi/memory_hotplug.h |   1 +
> >   include/hw/acpi/pc-hotplug.h     |   1 +
> >   include/hw/mem/nvdimm.h          |   6 +-
> >   include/hw/mem/pc-dimm.h         |   1 +
> >   13 files changed, 278 insertions(+), 40 deletions(-)
>
> I left comments on two patches.  I'm not very familiar with ACPI and
> memory hotplug but I've tried my best to review the series.

You are good enough. :)

I really appreciate your great efforts to continuously review and push nvdimm's
patches.

Thanks!