[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix off-by-one bug
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix off-by-one bug |
Date: |
Fri, 15 Jul 2016 12:10:47 +0200 |
On Di, 2016-07-12 at 17:31 +0800, Herongguang (Stephen) wrote:
> In tight_encode_indexed_rect32, buf(or src)’s size is count. In for loop,
> the logic is supposed to be that i is an index into src, i should be
> incremented when incrementing src.
>
> This is broken when src is incremented but i is not before while loop,
> resulting in off-by-one bug in while loop.
>
> Signed-off-by: He Rongguang <address@hidden>
Added to vnc queue.
Patch is whitespace mangled, had to use "patch --ignore-whitespace" to
get it applied. Can you please use 'git send-email' to send patches in
the future? That is the best way to avoid your mail client breaking
patches.
thanks,
Gerd