[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] target-ppc: fix left shift overflow in hpte_page_sh
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH] target-ppc: fix left shift overflow in hpte_page_shift |
Date: |
Fri, 15 Jul 2016 17:22:10 +0200 |
ps->pte_enc is a 32-bit value, which is shifted left and then compared
to a 64-bit value. It needs a cast before the shift.
Reported by Coverity.
Signed-off-by: Paolo Bonzini <address@hidden>
---
target-ppc/mmu-hash64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c
index 82c2186..8f7e5b4 100644
--- a/target-ppc/mmu-hash64.c
+++ b/target-ppc/mmu-hash64.c
@@ -479,7 +479,7 @@ static unsigned hpte_page_shift(const struct
ppc_one_seg_page_size *sps,
mask = ((1ULL << ps->page_shift) - 1) & HPTE64_R_RPN;
- if ((pte1 & mask) == (ps->pte_enc << HPTE64_R_RPN_SHIFT)) {
+ if ((pte1 & mask) == ((uint64_t)ps->pte_enc << HPTE64_R_RPN_SHIFT)) {
return ps->page_shift;
}
}
--
2.7.4
- [Qemu-devel] [PATCH] target-ppc: fix left shift overflow in hpte_page_shift,
Paolo Bonzini <=