[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] trace: [bsd-user] Commandline arguments
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] trace: [bsd-user] Commandline arguments to control tracing |
|
Date: |
Fri, 15 Jul 2016 13:22:54 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/15/2016 11:08 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> bsd-user/main.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> @@ -754,6 +760,8 @@ int main(int argc, char **argv)
>
> cpu_model = NULL;
>
> + qemu_add_opts(&qemu_trace_opts);
> +
> optind = 1;
> for(;;) {
Optional, but since you are in the area, you could add the missing space
after 'for'.
> if (optind >= argc)
> @@ -840,6 +848,9 @@ int main(int argc, char **argv)
> singlestep = 1;
> } else if (!strcmp(r, "strace")) {
> do_strace = 1;
> + } else if (!strcmp(r, "trace")) {
> + g_free(trace_file);
> + trace_file = trace_opt_parse(optarg);
> } else
> {
and fix the 'else {' to be on one line.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature