Re: [Qemu-devel] [PATCH] migration: set state to post-migrate on failure

[Amit Shah]

On (Fri) 15 Jul 2016 [17:44:46], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> If a migration fails/is cancelled during the postcopy stage we currently
> end up with the runstate as finish-migrate, where it should be post-migrate.
> There's a small window in precopy where I think the same thing can
> happen, but I've never seen it.
> 
> It rarely matters; the only postcopy case is if you restart a migration, which
> again is a case that rarely matters in postcopy because it's only
> safe to restart the migration if you know the destination hasn't
> been running (which you might if you started the destination with -S
> and hadn't got around to 'c' ing it before the postcopy failed).
> Even then it's a small window but potentially you could hit if
> there's a problem loading the devices on the destination.
> 
> This corresponds to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1355683
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>

Reviewed-by: Amit Shah <address@hidden>

                Amit