qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid patches
Date: Mon, 18 Jul 2016 15:15:40 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1


On 18/07/2016 14:15, Stefan Hajnoczi wrote:
> On Fri, Jul 15, 2016 at 10:46:54AM +0100, Stefan Hajnoczi wrote:
>> Renames look like this with git-diff(1) when diff.renames = true is set:
>>
>>   diff --git a/a b/b
>>   similarity index 100%
>>   rename from a
>>   rename to b
>>
>> This raises the "Does not appear to be a unified-diff format patch"
>> error because checkpatch.pl only considers a diff valid if it contains
>> at least one "@@" hunk.
>>
>> This patch accepts renames and copies too so that checkpatch.pl exits
>> successfully when a diff only renames/copies files.  The git diff
>> extended header format is described on the git-diff(1) man page.
>>
>> Reported-by: Colin Lord <address@hidden>
>> Signed-off-by: Stefan Hajnoczi <address@hidden>
>> ---
>>  scripts/checkpatch.pl | 5 +++++
>>  1 file changed, 5 insertions(+)
> 
> There is no maintainer for checkpatch.pl, so...
> 
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block

Actually I've sent a pull request for this patch too this morning
(forgot to sent the "applied" message because at the time I applied it I
was offline), but Peter bumped it.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]